Re: OPL3SA2: spin_is_locked on uninitialized spinlock

From: Andrew Morton
Date: Wed Aug 13 2003 - 07:08:22 EST


Felipe Alfaro Solana <felipe_alfaro@xxxxxxxxxxxxx> wrote:
>
> I've found a lot of errors like this when loading the OPL3SA2 sound
> driver on my old Intel AL440LX computer, running 2.6.0-test3-mm1:
>
> sound/isa/opl3sa2.c:204: spin_is_locked on uninitialized spinlock
> d6200034.

Does this help?

diff -puN sound/isa/opl3sa2.c~opl3sa2-lock-init-fix sound/isa/opl3sa2.c
--- 25/sound/isa/opl3sa2.c~opl3sa2-lock-init-fix 2003-08-13 05:03:32.000000000 -0700
+++ 25-akpm/sound/isa/opl3sa2.c 2003-08-13 05:04:06.000000000 -0700
@@ -752,6 +752,7 @@ static int __devinit snd_opl3sa2_probe(i
err = -ENOMEM;
goto __error;
}
+ spin_lock_init(&chip->reg_lock);
chip->irq = -1;
if ((err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops)) < 0)
goto __error;

_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/