Re: [PATCH] read_trylock for i386

From: Christoph Hellwig
Date: Wed Aug 13 2003 - 01:27:24 EST


On Tue, Aug 12, 2003 at 11:14:17PM -0700, Roland McGrath wrote:
> The following header patches add the read_trylock macro, implementing it
> fully for i386 and leaving other architectures with an always-fail fallback.
> Other architectures include/asm-foo/spinlock.h files should define
> _raw_read_trylock appropriately and define HAVE_ARCH_RAW_READ_TRYLOCK. But
> until they do, machine-independent code can use read_trylock for optimization
> purposes (i.e. where it falls back to using read_lock) and architectures that
> haven't implemented it will just not be getting the optimization.

I strongy dislike the always-fail case. Just let the other arches fail
until the arch maintainers update them.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/