Re: [PATCH] Remove useless assertions from reiserfs

[Jeff Garzik]

Dave Jones wrote:
> On Mon, Aug 11, 2003 at 01:45:30PM -0400, Jeff Garzik wrote:
>  > Why are these useless?
>
> read the code not the diff.
>
>  > >@@ -90,10 +90,6 @@ u32 keyed_hash(const signed char *msg, i
>  > > 
>  > > 	if (len >= 12)
>  > > 	{
>  > >-	    	//assert(len < 16);
>  > >-		if (len >= 16)
>  > >-		    BUG();
>  > >-
>  > > 		a = (u32)msg[ 0]      |
>  > > 		    (u32)msg[ 1] << 8 |
>  > > 		    (u32)msg[ 2] << 16|
>  > 
>  > Seems like a valid check to me...
>
> Above this loop is another loop which we don't exit until len < 16

ok, agreed

	Jeff




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/