Re: PATCH: mouse and keyboard by default if not embedded

[Geert Uytterhoeven]

On Sun, 27 Jul 2003, Alan Cox wrote:
> (Andi Kleen)
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.6.0-test2/drivers/input/Kconfig linux-2.6.0-test2-ac1/drivers/input/Kconfig
> --- linux-2.6.0-test2/drivers/input/Kconfig	2003-07-10 21:04:59.000000000 +0100
> +++ linux-2.6.0-test2-ac1/drivers/input/Kconfig	2003-07-16 18:39:32.000000000 +0100
> @@ -5,7 +5,7 @@
>  menu "Input device support"
>  
>  config INPUT
> -	tristate "Input devices (needed for keyboard, mouse, ...)"
> +	tristate "Input devices (needed for keyboard, mouse, ...)" if EMBEDDED
>  	default y
>  	---help---
>  	  Say Y here if you have any input device (mouse, keyboard, tablet,
> @@ -27,7 +27,7 @@
>  comment "Userland interfaces"
>  
>  config INPUT_MOUSEDEV
> -	tristate "Mouse interface"
> +	tristate "Mouse interface" if EMBEDDED
>  	default y
>  	depends on INPUT
>  	---help---
> @@ -45,7 +45,7 @@
>  	  a module, say M here and read <file:Documentation/modules.txt>.
>  
>  config INPUT_MOUSEDEV_PSAUX
> -	bool "Provide legacy /dev/psaux device"
> +	bool "Provide legacy /dev/psaux device" if EMBEDDED

Now INPUT_MOUSEDEV_PSAUX is always (on non-embedded machines) forced to true,
even on machines without PS/2 keyboard/mouse hardware. Is that OK?

So far (compiling, not running 2.6.0-test3) I didn't notice any problems,
though.

>  	default y
>  	depends on INPUT_MOUSEDEV
>  
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.6.0-test2/drivers/input/keyboard/Kconfig linux-2.6.0-test2-ac1/drivers/input/keyboard/Kconfig
> --- linux-2.6.0-test2/drivers/input/keyboard/Kconfig	2003-07-10 21:14:55.000000000 +0100
> +++ linux-2.6.0-test2-ac1/drivers/input/keyboard/Kconfig	2003-07-16 18:39:32.000000000 +0100
> @@ -2,7 +2,7 @@
>  # Input core configuration
>  #
>  config INPUT_KEYBOARD
> -	bool "Keyboards"
> +	bool "Keyboards" if (X86 && EMBEDDED) || (!X86)
>  	default y
>  	depends on INPUT
>  	help
> @@ -12,7 +12,7 @@
>  	  If unsure, say Y.
>  
>  config KEYBOARD_ATKBD
> -	tristate "AT keyboard support"
> +	tristate "AT keyboard support" if (X86 && EMBEDDED) || (!X86) 
>  	default y
>  	depends on INPUT && INPUT_KEYBOARD && SERIO
>  	help

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/