Re: Badness in device_release at drivers/base/core.c:84

From: Diffie (diffie@blazebox.homeip.net)
Date: Sat Aug 02 2003 - 20:55:10 EST


On Fri, Aug 01, 2003 at 02:44:55PM -0700, Andrew Morton wrote:
> Diffie <diffie@blazebox.homeip.net> wrote:
> >
> > Unable to handle kernel NULL pointer dereference at virtual address 00000120
> > printing eip:
> > c02a8cae
> > *pde = 00000000
> > Oops: 0000 [#1]
> > PREEMPT
> > CPU: 0
> > EIP: 0060:[<c02a8cae>] Not tainted VLI
> > EFLAGS: 00210286
> > EIP is at aic7xxx_proc_info+0x2e/0xc80
> > eax: c1bb25b0 ebx: c1bb2400 ecx: c038bb20 edx: 00000000
> > esi: 00000400 edi: f1715000 ebp: 412de000 esp: f620fecc
> > ds: 007b es: 007b ss: 0068
> > Process nautilus (pid: 3555, threadinfo=f620e000 task=f6216720)
> > Stack: 000001f7 00000000 00000000 c013c612 c0379eb0 00000000 00000000 f6613340
> > 00000000 00000000 c0379eb0 00000400 00000400 f1715000 412de000 c02956fc
> > c1bb2400 f1715000 f620ff60 00000000 00000400 00000000 c02956c0 c018bc91
> > Call Trace:
> > [<c013c612>] __alloc_pages+0x92/0x320
> > [<c02956fc>] proc_scsi_read+0x3c/0x60
> > [<c02956c0>] proc_scsi_read+0x0/0x60
>
> This patch should fix the oops.
>
> As for why the proc reading code was unable to locate the HBA: dunno, but
> this is a first step.
>
> Or maybe you don't have any adaptec controllers in the machine?
>
> (jejb, please apply..)
>
>
> 25-akpm/drivers/scsi/aic7xxx_old/aic7xxx_proc.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/scsi/aic7xxx_old/aic7xxx_proc.c~aic7xxx_old-oops-fix drivers/scsi/aic7xxx_old/aic7xxx_proc.c
> --- 25/drivers/scsi/aic7xxx_old/aic7xxx_proc.c~aic7xxx_old-oops-fix Fri Aug 1 14:41:14 2003
> +++ 25-akpm/drivers/scsi/aic7xxx_old/aic7xxx_proc.c Fri Aug 1 14:41:20 2003
> @@ -92,7 +92,7 @@ aic7xxx_proc_info ( struct Scsi_Host *HB
>
> HBAptr = NULL;
>
> - for(p=first_aic7xxx; p->host != HBAptr; p=p->next)
> + for(p=first_aic7xxx; p && p->host != HBAptr; p=p->next)
> ;
>
> if (!p)
>
> _
>
>

Andrew,

After applaying the above patch and testing it still oopses the kernel.

I noticed same patch in today's mm3 which i compiled and use right now.

When using cat /proc/scsi/aic7xxx/0 i get segmentation fault and oops
which i'll attach to this email.

uname: Linux blaze 2.6.0-test2-mm3 #1 Sat Aug 2 20:12:35 EDT 2003 i686 unknown

gcc version 3.2.2 on Slackware 9.0

I noticed this when the SCSI sybsystem is initialized upon boot:
scsi: Device offlined - not ready after error recovery: host 0 channel 0 id 1 lun 0

Regards,

Paul B.

















-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 07 2003 - 22:00:20 EST