Re: [PATCH] [2.5] reiserfs: fix races between link and unlink on same file

• Next message: Andrew Morton: "Re: [PATCH] RCU: Reduce size of rcu_head 1 of 2"
• Previous message: Dipankar Sarma: "[PATCH] Monitor RCU grace period"
• In reply to: Oleg Drokin: "[PATCH] [2.5] reiserfs: fix races between link and unlink on same file"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Oleg Drokin <green@namesys.com> wrote:
>
> This patch (originally by Chris Mason) fixes link/unlink races in reiserfs.
>

Could you describe the race a little more please? Why is the VFS's hold of
i_sem on the parent directory not sufficient?

> +
> + /*
> + * we schedule before doing the add_save_link call, save the link
> + * count so we don't race

This comment would seem to imply lock_kernel()-based locking, but
lock_kernel() is not held here.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Andrew Morton: "Re: [PATCH] RCU: Reduce size of rcu_head 1 of 2"
• Previous message: Dipankar Sarma: "[PATCH] Monitor RCU grace period"
• In reply to: Oleg Drokin: "[PATCH] [2.5] reiserfs: fix races between link and unlink on same file"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Jul 31 2003 - 22:00:51 EST