Re: [PATCH] reorganize USB submenu's

From: Roman Zippel (zippel@linux-m68k.org)
Date: Thu Jul 31 2003 - 12:45:29 EST


On Thu, 31 Jul 2003, Stephen Hemminger wrote:

> diff -Nru a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> --- a/drivers/usb/gadget/Kconfig Thu Jul 31 10:07:11 2003
> +++ b/drivers/usb/gadget/Kconfig Thu Jul 31 10:07:11 2003
> @@ -6,9 +6,12 @@
> # for 2.5 kbuild, drivers/usb/gadget/Kconfig
> # source this at the end of drivers/usb/Kconfig
> #
> -menuconfig USB_GADGET
> +menu "USB Gadgets"
> + depends on USB!=n
> +
> +config USB_GADGET
> tristate "Support for USB Gadgets"
> - depends on EXPERIMENTAL
> + depends on USB && EXPERIMENTAL
> help
> USB is a master/slave protocol, organized with one master
> host (such as a PC) controlling up to 127 peripheral devices.

Why do you remove the menuconfig?
USB_GADGET is independent of USB.

> diff -Nru a/drivers/usb/input/Kconfig b/drivers/usb/input/Kconfig
> --- a/drivers/usb/input/Kconfig Thu Jul 31 10:07:11 2003
> +++ b/drivers/usb/input/Kconfig Thu Jul 31 10:07:11 2003
> @@ -1,8 +1,10 @@
> #
> # USB Input driver configuration
> #
> -comment "USB Human Interface Devices (HID)"
> - depends on USB
> +menu "USB Input devices"
> +
> +comment "Input core support is needed for USB HID input layer or HIDBP support"
> + depends on USB && INPUT=n
>
> config USB_HID
> tristate "USB Human Interface Device (full HID) support"

The menu needs to depend on USB otherwise you'll have empty menus if USB
is disabled (the same is true for storage/media/net).

bye, Roman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jul 31 2003 - 22:00:50 EST