Re: [PATCH] select fix

From: Manfred Spraul (manfred@colorfullife.com)
Date: Tue Jul 29 2003 - 12:57:04 EST

Next message: juan l.: "Re: [PATCH] ALSA update 0.9.6"
Previous message: Trond Myklebust: "Re: NFS weirdness in 2.6.0-test1"
In reply to: Andrew Morton: "Re: [PATCH] select fix"
Next in thread: Andries.Brouwer@cwi.nl: "Re: [PATCH] select fix"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Andrew Morton wrote:

>Andries.Brouwer@cwi.nl wrote:
>
>
>>- if (tty->driver->chars_in_buffer(tty) < WAKEUP_CHARS)
>>+ if (!tty->stopped && tty->driver->chars_in_buffer(tty) < WAKEUP_CHARS)
>> mask |= POLLOUT | POLLWRNORM;
>>
>>
>
>Manfred sent a patch through esterday which addresses it this way:
>
>- if (tty->driver->chars_in_buffer(tty) < WAKEUP_CHARS)
>+ if (tty->driver->chars_in_buffer(tty) < WAKEUP_CHARS &&
>+ tty->driver->write_room(tty) > 0)
>
>Any preferences?
>
>
Who should implement tty->stopped? AFAICS tty->stopped is implemented in
the drivers right now, and my patch would leave that unchanged.

-- Manfred

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: juan l.: "Re: [PATCH] ALSA update 0.9.6"
Previous message: Trond Myklebust: "Re: NFS weirdness in 2.6.0-test1"
In reply to: Andrew Morton: "Re: [PATCH] select fix"
Next in thread: Andries.Brouwer@cwi.nl: "Re: [PATCH] select fix"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Jul 31 2003 - 22:00:42 EST