Re: Assorted 2.6.0-test2 build warnings

From: Adrian Bunk (bunk@fs.tum.de)
Date: Tue Jul 29 2003 - 05:42:10 EST

Next message: Balram Adlakha: "Re: 2.6.0-test1 NFS file transfer"
Previous message: Mikael Pettersson: "Re: ACPI failure (2.6.0-test<x> and 2.4.22-pre<x>)"
In reply to: Randy.Dunlap: "Re: Assorted 2.6.0-test2 build warnings"
Next in thread: Bill Davidsen: "Re: [2.4 PATCH] bugfix: ARP respond on all devices"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, Jul 28, 2003 at 03:11:04PM -0700, Randy.Dunlap wrote:
> On Sun, 27 Jul 2003 20:57:31 -0400 "J.C. Wren" <jcwren@jcwren.com> wrote:
>
> | Assorted warnings building 2.6.0-test2, on an Athlon:
> |
> | CC fs/ntfs/super.o
> | fs/ntfs/super.c: In function `is_boot_sector_ntfs':
> | fs/ntfs/super.c:375: warning: integer constant is too large for "long" type
>
> Please see if the patch below fixes this one.
>...
> ~Randy
>
>
> patch_name: ntfs_ulong.patch
> patch_version: 2003-07-28.14:29:57
> author: Randy.Dunlap <rddunlap@osdl.org>
> description: make a constant be UL;
> product: Linux
> product_versions: 2.6.0-test2
> maintainer: Anton Altaparmakov <aia21@cantab.net>
> diffstat: =
> fs/ntfs/layout.h | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
>
> diff -Naurp ./fs/ntfs/layout.h~type ./fs/ntfs/layout.h
> --- ./fs/ntfs/layout.h~type 2003-07-27 10:02:48.000000000 -0700
> +++ ./fs/ntfs/layout.h 2003-07-28 14:05:20.000000000 -0700
> @@ -43,7 +43,7 @@
> #define const_cpu_to_le64(x) __constant_cpu_to_le64(x)
>
> /* The NTFS oem_id */
> -#define magicNTFS const_cpu_to_le64(0x202020205346544e) /* "NTFS " */
> +#define magicNTFS const_cpu_to_le64(0x202020205346544eUL) /* "NTFS " */
>...

s/UL/ULL/ (your patch fixed only 64 bit architectures)

The fix is already in Rusty's trivial patch.

cu
Adrian

"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Balram Adlakha: "Re: 2.6.0-test1 NFS file transfer"
Previous message: Mikael Pettersson: "Re: ACPI failure (2.6.0-test<x> and 2.4.22-pre<x>)"
In reply to: Randy.Dunlap: "Re: Assorted 2.6.0-test2 build warnings"
Next in thread: Bill Davidsen: "Re: [2.4 PATCH] bugfix: ARP respond on all devices"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Jul 31 2003 - 22:00:39 EST