On Sun, Jul 27 2003, Bernardo Innocenti wrote:
> On Saturday 26 July 2003 16:07, Jens Axboe wrote:
>
> > > /*
> > > * linux/drivers/block/as-iosched.c
> > > *
> > > - * Anticipatory & deadline i/o scheduler.
> > > + * Anticipatory i/o scheduler.
> > > *
> > > * Copyright (C) 2002 Jens Axboe <axboe@suse.de>
> > > * Nick Piggin <piggin@cyberone.com.au>
> >
> > Huh? What is that about? AS is deadline + anticipation. Good rule is not
> > to make comment changes when you don't know your changes to be a fact.
>
> Oops, I thought it was done by mistake :-)
>
> By the way, this comment in as-iosched.c refers to a missing file:
>
> /*
> * See Documentation/as-iosched.txt
> */
Hmm odd, maybe it never got migrated from Andrews tree.
> Another issue: to make the I/O schedulers configurable, I had to
> fiddle with ll_rw_blk.c, makiing it slightly harder to understand.
Don't worry, the current addon of additional schedulers is crap already,
so your patch has to deal with that. The real modular schedulers will
change this, removing the nasty bits that are there know. It doesn't
even belong in ll_rw_blk.c
> > About making it selectable, I'm fine with it. Please send an updated
> > patch.
>
> Here it is:
Thanks
-- Jens Axboe- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Jul 31 2003 - 22:00:30 EST