Re: [PATCH] Make I/O schedulers optional (Was: Re: Kernel 2.6 size increase)

From: Jens Axboe (axboe@suse.de)
Date: Sat Jul 26 2003 - 09:07:45 EST

Next message: Eli Barzilay: "Re: Repost: Bug with select?"
Previous message: Daniel Egger: "Re: Reiser4 status: benchmarked vs. V3 (and ext3)"
In reply to: Bernardo Innocenti: "Re: [PATCH] Make I/O schedulers optional (Was: Re: Kernel 2.6 size increase)"
Next in thread: Bernardo Innocenti: "Re: [PATCH] Make I/O schedulers optional (Was: Re: Kernel 2.6 size increase)"
Reply: Bernardo Innocenti: "Re: [PATCH] Make I/O schedulers optional (Was: Re: Kernel 2.6 size increase)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, Jul 26 2003, Bernardo Innocenti wrote:
> diff -Nru linux-2.6.0-test1.orig/drivers/block/as-iosched.c linux-2.6.0-test1-with_elevator_patch/drivers/block/as-iosched.c
> --- linux-2.6.0-test1.orig/drivers/block/as-iosched.c 2003-07-14 05:28:54.000000000 +0200
> +++ linux-2.6.0-test1-with_elevator_patch/drivers/block/as-iosched.c 2003-07-25 20:19:44.000000000 +0200
> @@ -1,7 +1,7 @@
> /*
> * linux/drivers/block/as-iosched.c
> *
> - * Anticipatory & deadline i/o scheduler.
> + * Anticipatory i/o scheduler.
> *
> * Copyright (C) 2002 Jens Axboe <axboe@suse.de>
> * Nick Piggin <piggin@cyberone.com.au>

Huh? What is that about? AS is deadline + anticipation. Good rule is not
to make comment changes when you don't know your changes to be a fact.

About making it selectable, I'm fine with it. Please send an updated
patch.

-- Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Eli Barzilay: "Re: Repost: Bug with select?"
Previous message: Daniel Egger: "Re: Reiser4 status: benchmarked vs. V3 (and ext3)"
In reply to: Bernardo Innocenti: "Re: [PATCH] Make I/O schedulers optional (Was: Re: Kernel 2.6 size increase)"
Next in thread: Bernardo Innocenti: "Re: [PATCH] Make I/O schedulers optional (Was: Re: Kernel 2.6 size increase)"
Reply: Bernardo Innocenti: "Re: [PATCH] Make I/O schedulers optional (Was: Re: Kernel 2.6 size increase)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Jul 31 2003 - 22:00:28 EST