[PATCH] uninitialized spinlock in drivers/net/sk_mca.c

From: Francois Romieu (romieu@fr.zoreil.com)
Date: Fri Jul 25 2003 - 17:37:05 EST


A spinlock was recently added to struct skmca_priv so as to remove
save_flags()/cli() but nothing in the current code initializes it.

If the adequate diplodocus lurks in somebody's kitchen to test the patch...

 drivers/net/sk_mca.c | 1 +
 1 files changed, 1 insertion(+)

diff -puN drivers/net/sk_mca.c~drivers-sk_mca-spinlock_init drivers/net/sk_mca.c
--- linux-2.6.0-test1-bk2/drivers/net/sk_mca.c~drivers-sk_mca-spinlock_init Sat Jul 26 00:12:52 2003
+++ linux-2.6.0-test1-bk2-fr/drivers/net/sk_mca.c Sat Jul 26 00:15:35 2003
@@ -1155,6 +1155,7 @@ int __init skmca_probe(struct SKMCA_NETD
         priv->cmdaddr = base + 0x3ff3;
         priv->medium = medium;
         memset(&(priv->stat), 0, sizeof(struct net_device_stats));
+ spin_lock_init(&priv->lock);
 
         /* set base + irq for this device (irq not allocated so far) */
         dev->irq = 0;

_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Jul 31 2003 - 22:00:27 EST