Re: BUG in pdc202xx_old.c

From: Alan Cox (alan@lxorguk.ukuu.org.uk)
Date: Sun Jul 20 2003 - 18:31:05 EST


On Sul, 2003-07-20 at 21:06, Jürgen Stohr wrote:
> * check to make sure drive on same channel
> * is u66 capable
> */
> - if (hwif->drives[!(drive->dn%2)].id) {
> + if (hwif->drives[!(drive->dn%2)].present) {

This doesn't really seem to make sense for current IDE - drive[n].id is
never NULL. On old systems it was and this test was needed so we didnt
check ultra dma flags on an ident free drive (old ST506 etc)

That makes me curious as to what is really going on here.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jul 23 2003 - 22:00:41 EST