Andrew wrote:
>> - qla2x00_intr_handler should use spin_lock, not spin_lock_irqsave
>
>Are you sure about that? I'll need to refresh my interrupt handling
>know-how...
>
>
It's an optimization that is used by many drivers:
Interrupt handlers are never reentered - if you are within
qla2x00_intr_handler handling irq x, then it's guaranteed that the
function won't be reentered by another occurance of the same interrupt.
If your driver registers only one interrupt handler, then you can skip
disabling the local interrupts - a deadlock is not possible.
You need _irqsave if the spinlock is shared between multiple instances
of the hba, with different interrupts (i.e. it's possible that
qla2x00_intr_handler is called for irq y while handling irq x).
--
Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Jul 23 2003 - 22:00:36 EST