On Thu, Jul 03, 2003 at 01:44:55PM -0400, Stephen Smalley wrote:
> The patch against 2.5.74-bk1 available from
> http://www.nsa.gov/selinux/lk/2.5.74-bk1-selinux.patch.gz adds the
> SELinux module to the tree and modifies the security/Makefile and
> security/KConfig files for SELinux. The last dependency for SELinux,
> the vm_enough_memory security hook, was included in -bk1. Please
> consider applying. Thanks. diffstat output is below.
nitpicks:
1) "selinux" is a poor toplevel directory. We already have the toplevel
"security" directory, this code should go in there.
2) stick includes in the standard include/ directory. I would suggest
include/security (if the headers are general) or
include/security/selinux.
3) I wonder if the kernel should have a generic hash table ADT?
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Jul 07 2003 - 22:00:20 EST