[PATCH 1/4] Remove unused __syscall_count from irq_cpustat_t.

From: Rusty Russell (rusty@rustcorp.com.au)
Date: Thu Jul 03 2003 - 03:08:02 EST


In message <Pine.LNX.4.44.0307030035420.8776-100000@home.osdl.org> you write:
>
> On Thu, 3 Jul 2003, Rusty Russell wrote:
> >
> > Linus, please apply. Small diff overlap with previous patch, and next
> > patch.
>
> This arrived in the wrong order, and because it was dependent on another
> patch, and there was no explicit ordering, it didn't apply.

As ordered, here is 1/4:

Noone seems to use __syscall_count. Remove the field from i386
irq_cpustat_t struct, and the generic accessor macros.

Because some archs have hardcoded asm references to offsets in this
structure, I haven't touched non-x86, but doing so is usually
trivial.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

Name: Remove unused __syscall_count from irq_stat struct. Author: Rusty Russell Status: Tested on 2.5.74

D: Noone seems to use __syscall_count. Remove the field from i386 D: irq_cpustat_t struct, and the generic accessor macros. D: D: Because some archs have hardcoded asm references to offsets in this D: structure, I haven't touched non-x86, but doing so is usually D: trivial.

diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .2143-linux-2.5.73-bk8/include/asm-i386/hardirq.h .2143-linux-2.5.73-bk8.updated/include/asm-i386/hardirq.h --- .2143-linux-2.5.73-bk8/include/asm-i386/hardirq.h 2003-04-08 11:14:55.000000000 +1000 +++ .2143-linux-2.5.73-bk8.updated/include/asm-i386/hardirq.h 2003-07-01 13:49:21.000000000 +1000 @@ -7,7 +7,6 @@ typedef struct { unsigned int __softirq_pending; - unsigned int __syscall_count; struct task_struct * __ksoftirqd_task; /* waitqueue is too large */ unsigned long idle_timestamp; unsigned int __nmi_count; /* arch dependent */ diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .2143-linux-2.5.73-bk8/include/linux/irq_cpustat.h .2143-linux-2.5.73-bk8.updated/include/linux/irq_cpustat.h --- .2143-linux-2.5.73-bk8/include/linux/irq_cpustat.h 2003-06-15 11:30:08.000000000 +1000 +++ .2143-linux-2.5.73-bk8.updated/include/linux/irq_cpustat.h 2003-07-01 13:48:58.000000000 +1000 @@ -29,8 +29,6 @@ extern irq_cpustat_t irq_stat[]; /* def /* arch independent irq_stat fields */ #define softirq_pending(cpu) __IRQ_STAT((cpu), __softirq_pending) #define local_softirq_pending() softirq_pending(smp_processor_id()) -#define syscall_count(cpu) __IRQ_STAT((cpu), __syscall_count) -#define local_syscall_count() syscall_count(smp_processor_id()) #define ksoftirqd_task(cpu) __IRQ_STAT((cpu), __ksoftirqd_task) #define local_ksoftirqd_task() ksoftirqd_task(smp_processor_id()) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Jul 07 2003 - 22:00:18 EST