Re: [PATCH] Isapnp warning

From: Jan-Benedict Glaw (jbglaw@lug-owl.de)
Date: Sun Jun 22 2003 - 10:00:05 EST

Next message: Michael Buesch: "Re: Warning messages during compilation of 2.4.21. (5 files)"
Previous message: Jay Denebeim: "Re: Redhat 2.4.20 kernel problems"
In reply to: Daniel Phillips: "Re: [PATCH] Isapnp warning"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, 2003-06-22 16:07:14 +0200, Daniel Phillips <phillips@arcor.de>
wrote in message <200306221607.15232.phillips@arcor.de>:
> Hi Alan,
>
> On Saturday 21 June 2003 14:31, Alan Cox wrote:
> > On Sul, 2003-06-15 at 19:36, Geert Uytterhoeven wrote:
>
> How about:
>
> #define if_pci(tokens...) tokens
>
> int pnp_add_irq_resource(struct pnp_dev *dev, int depnum, struct pnp_irq *data)
> {
> if_pci(int i);
> ...
> }
>
> Admittedly uglier than just having the warning disabled by default.

Even whilest I don't like defining variables where I need them (at an
opening "{" or like in "for (int i, i < x, i++)" as Linus suggested it),
this is quite ugly, too. "if_pci(int i)" looks linke an uglyfied
function call, and even while being ugly, it should basically "work"
like a function call. Here, it doesn't, so I consider this a Bad Thing.

MfG, JBG

-- 
   Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481
   "Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg
    fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!
      ret = do_actions((curr | FREE_SPEECH) & ~(IRAQ_WAR_2 | DRM | TCPA));

application/pgp-signature attachment: stored

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Michael Buesch: "Re: Warning messages during compilation of 2.4.21. (5 files)"
Previous message: Jay Denebeim: "Re: Redhat 2.4.20 kernel problems"
In reply to: Daniel Phillips: "Re: [PATCH] Isapnp warning"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Jun 23 2003 - 22:00:38 EST