Re: [PATCH] buffer_insert_list should use list_add_tail

From: Nathan Scott (nathans@sgi.com)
Date: Thu Jun 19 2003 - 18:11:17 EST

Next message: Adrian Bunk: "[2.5 patch] remove two unused variables from mxser.c"
Previous message: Daniel McNeil: "[PATCH 2.7.72-mm1] aio wait on io_queue_wait()"
In reply to: Chris Mason: "[PATCH] buffer_insert_list should use list_add_tail"
Next in thread: Christoph Hellwig: "Re: [PATCH] buffer_insert_list should use list_add_tail"
Reply: Christoph Hellwig: "Re: [PATCH] buffer_insert_list should use list_add_tail"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, Jun 19, 2003 at 09:15:39AM -0400, Chris Mason wrote:
> Hello all,
>
> buffer_insert_list puts buffers onto the head of bh->b_inode_buffers,
> which means that on fsync we are writing things out in reverse order. I
> think we either want this patch, or we want to walk the list in reverse
> in fsync_buffers_list
>
> (this has not been well tested, but I can't think of any problems it
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> would cause)

hi Chris,

We noticed this too and Christoph made this change in the
2.4 XFS tree a little while ago - let me check dates - ah,
9th May. So, fair bit of testing here and we've not seen
any issues from this change either (we'd also like to see
it merged).

thanks.

>
> -chris
>
> --- linux.marcelo/fs/buffer.c Thu Jun 19 09:09:28 2003
> +++ linux/fs/buffer.c Thu Jun 19 09:04:17 2003
> @@ -591,7 +604,7 @@
> if (buffer_attached(bh))
> list_del(&bh->b_inode_buffers);
> set_buffer_attached(bh);
> - list_add(&bh->b_inode_buffers, list);
> + list_add_tail(&bh->b_inode_buffers, list);
> spin_unlock(&lru_list_lock);
> }
>
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

-- 
Nathan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Adrian Bunk: "[2.5 patch] remove two unused variables from mxser.c"
Previous message: Daniel McNeil: "[PATCH 2.7.72-mm1] aio wait on io_queue_wait()"
In reply to: Chris Mason: "[PATCH] buffer_insert_list should use list_add_tail"
Next in thread: Christoph Hellwig: "Re: [PATCH] buffer_insert_list should use list_add_tail"
Reply: Christoph Hellwig: "Re: [PATCH] buffer_insert_list should use list_add_tail"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Jun 23 2003 - 22:00:31 EST