Re: [PATCH] Fix undefined/miscompiled construct in kernel parameters

From: Richard Henderson (rth@twiddle.net)
Date: Sun Jun 15 2003 - 19:49:57 EST


On Mon, Jun 16, 2003 at 10:23:41AM +1000, Rusty Russell wrote:
> Since Andi reports that even that doesn't work for x86-64, I'd say
> apply this patch based on his: it's an arbitrary change anyway.

No, Andi located the *real* problem. The compiler was over-aligning
these objects, which added padding, which broke the array semantics
you were looking for. The solution is to add an attribute aligned;
he's sent a patch to Linus already.

r~
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:43 EST