Re: [PATCH] Fix undefined/miscompiled construct in kernel parameters

From: Roman Zippel (zippel@linux-m68k.org)
Date: Sun Jun 15 2003 - 12:48:56 EST


Hi,

On 15 Jun 2003, Andi Kleen wrote:

> I tend to agree, feel free to flame them. But it doesn't help me right now
> when I want to get a booting kernel. Could you merge that change or if you
> prefer I can rewrite it to anonymous asm (but it will be probably more ugly).
> I just need some workaround.

Does the patch below work better?

bye, Roman

--- linux/init/main.c 14 Jun 2003 23:01:48 -0000 1.1.1.41
+++ linux/init/main.c 15 Jun 2003 17:46:16 -0000
@@ -383,7 +383,7 @@ asmlinkage void __init start_kernel(void
 {
         char * command_line;
         extern char saved_command_line[];
- extern struct kernel_param __start___param, __stop___param;
+ extern struct kernel_param __start___param[], __stop___param[];
 /*
  * Interrupts are still disabled. Do necessary setups, then
  * enable them
@@ -403,8 +403,8 @@ asmlinkage void __init start_kernel(void
         build_all_zonelists();
         page_alloc_init();
         printk("Kernel command line: %s\n", saved_command_line);
- parse_args("Booting kernel", command_line, &__start___param,
- &__stop___param - &__start___param,
+ parse_args("Booting kernel", command_line, __start___param,
+ __stop___param - __start___param,
                    &unknown_bootoption);
         trap_init();
         rcu_init();

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:42 EST