Re: [patch] input: Add PCI PS/2 controller support [5/13]

From: Vojtech Pavlik (vojtech@suse.cz)
Date: Sat Jun 14 2003 - 16:03:34 EST

Next message: Riley Williams: "RE: [patch] input: Fix CLOCK_TICK_RATE usage ... [8/13]"
Previous message: Russell King: "Re: [patch] input: Add PCI PS/2 controller support [5/13]"
In reply to: Oliver Neukum: "Re: [patch] input: Add PCI PS/2 controller support [5/13]"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, Jun 14, 2003 at 10:51:51PM +0200, Oliver Neukum wrote:

> > +static int pcips2_write(struct serio *io, unsigned char val)
> > +{
> > + struct pcips2_data *ps2if = io->driver;
> > + unsigned int stat;
> > +
> > + do {
> > + stat = inb(ps2if->base + PS2_STATUS);
> > + cpu_relax();
> > + } while (!(stat & PS2_STAT_TXEMPTY));
>
> What will happen if somebody unplugs the base station while this
> is running?

I suppose it will wait until you put the base station back. Russell, is
there any notification that the base is getting removed or do all the
loops need checking? I'd consider it not hotpluggable for now.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Riley Williams: "RE: [patch] input: Fix CLOCK_TICK_RATE usage ... [8/13]"
Previous message: Russell King: "Re: [patch] input: Add PCI PS/2 controller support [5/13]"
In reply to: Oliver Neukum: "Re: [patch] input: Add PCI PS/2 controller support [5/13]"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:40 EST