On Thu, Jun 12, 2003 at 10:24:16PM -0700, Trond Myklebust wrote:
> Wrong. Look at the VFS code. In all cases the test is of the form.
>
> spin_lock(&dcache_lock);
> /* Are we the sole users of this dentry */
> if (atomic_read(&dentry->d_count) == 1) {
> /* Yes - do some operation */
> }
>
>
> Knowing that d_lookup() can *increase* d_count is not a plus here. The
> whole idea is to have a test for sole use.
I missed this part. If you want to do this, I would suggest taking
the per-dentry lock instead. Most dcache routines have been fixed
to do this. We will look around and see anything violates this rule.
Thanks
Dipankar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:35 EST