Re: Looks like your PCI patch broke the PPC build (and others)?

• Next message: Eduardo Pereira Habkost: "Changes made by fdisk not being written to disk (2.5-bk)"
• Previous message: Unai Garro Arrazola: "2.5.70: Lilo needs patching?"
• In reply to: Benjamin Herrenschmidt: "Re: Looks like your PCI patch broke the PPC build (and others)?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Benjamin Herrenschmidt writes:

> Well... asm/pci-bridge.h includes linux/pci.h which includes asm/pci.h,
> so we have a circular include here...

True, but it seems that the multiple inclusion protection saves us. :)

> What I did in my tree is to move the definition of pci_controller
> from asm/pci-bridge.h to asm/pci.h. I'm now considering removing
> asm/pci-bridge.h, what do you think ?

We could do that. It might be simpler to just take pci_domain_nr out
of line again though.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Eduardo Pereira Habkost: "Changes made by fdisk not being written to disk (2.5-bk)"
• Previous message: Unai Garro Arrazola: "2.5.70: Lilo needs patching?"
• In reply to: Benjamin Herrenschmidt: "Re: Looks like your PCI patch broke the PPC build (and others)?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:34 EST