Re: [patch] as-iosched divide by zero fix

From: Robert Love (rml@tech9.net)
Date: Wed Jun 11 2003 - 20:28:39 EST


On Wed, 2003-06-11 at 18:22, Andrew Morton wrote:

> hrm, OK. Still not convinced about `batch'.

batch is only zero if {read,write}_batch_expire are zero. Nick, is that
legal/desirable? Or should we prevent that in the sysfs interface?

> - if (write_time / batch > 2)
> + if (write_time > batch * 2)
>
> - if (batch / write_time > 2)
> + if (batch > write_time * 2)

Much better! :)

        Robert Love

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:30 EST