Re: [PATCH] loop 6/9 remove LO_FLAGS_BH_REMAP

From: Jens Axboe (axboe@suse.de)
Date: Tue Jun 10 2003 - 10:42:27 EST

Next message: george anzinger: "Re: [PATCH] More time clean up stuff."
Previous message: Justin T. Gibbs: "Re: Undo aic7xxx changes (now rc7+aic20030603)"
In reply to: Hugh Dickins: "[PATCH] loop 6/9 remove LO_FLAGS_BH_REMAP"
Next in thread: Hugh Dickins: "[PATCH] loop 8/9 copy_bio use highmem"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Jun 10 2003, Hugh Dickins wrote:
> Jonah Sherman <jsherman@stuy.edu> pointed out back in February how
> LO_FLAGS_BH_REMAP is never actually set, since loop_init_xfer only calls
> the init for non-0 encryption type. Fix that or scrap it? Let's scrap
> it for now, that path (hacking values in bio instead of copying data)
> seems never to have been tested, and adds to the number of paths through
> loop: leave that optimization to some other occasion.

I agree with scrapping it, it's only really interesting for non-transfer
block direct remaps which can be done with dm or similar.

-- Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: george anzinger: "Re: [PATCH] More time clean up stuff."
Previous message: Justin T. Gibbs: "Re: Undo aic7xxx changes (now rc7+aic20030603)"
In reply to: Hugh Dickins: "[PATCH] loop 6/9 remove LO_FLAGS_BH_REMAP"
Next in thread: Hugh Dickins: "[PATCH] loop 8/9 copy_bio use highmem"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:24 EST