Re: [PATCH] IDE Power Management, try 3

From: Bartlomiej Zolnierkiewicz (B.Zolnierkiewicz@elka.pw.edu.pl)
Date: Tue Jun 10 2003 - 09:23:25 EST

Next message: Arnaldo Carvalho de Melo: "IDE OOPS in latest BK"
Previous message: Krzysztof Halasa: "Re: select for UNIX sockets?"
In reply to: Benjamin Herrenschmidt: "Re: [PATCH] IDE Power Management, try 3"
Next in thread: Benjamin Herrenschmidt: "Re: [PATCH] IDE Power Management, try 3"
Reply: Benjamin Herrenschmidt: "Re: [PATCH] IDE Power Management, try 3"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 10 Jun 2003, Benjamin Herrenschmidt wrote:

> On Fri, 2003-06-06 at 23:25, Bartlomiej Zolnierkiewicz wrote:
> > I have corrected it a bit and I am going to submit it, any comments?
> >
> > Ben, can you verify my changes and check that it still works after 'fixing'?
> > :-)
>
> Heh, thanks for the "corrections" ;)
>
> Regarding ide_wait_not_busy(), I'd rather have it return -ENODEV
> when it reads 0xff, what do you think ?

Nope, if you change it to return -ENODEV callers will fail.

> I'll test the patch later today (just back from a long week-end),
> Ben.

Good!

-- Bartlomiej

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Arnaldo Carvalho de Melo: "IDE OOPS in latest BK"
Previous message: Krzysztof Halasa: "Re: select for UNIX sockets?"
In reply to: Benjamin Herrenschmidt: "Re: [PATCH] IDE Power Management, try 3"
Next in thread: Benjamin Herrenschmidt: "Re: [PATCH] IDE Power Management, try 3"
Reply: Benjamin Herrenschmidt: "Re: [PATCH] IDE Power Management, try 3"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jun 15 2003 - 22:00:23 EST