Re: [PATCH] compile fix for MPT Fusion driver for 2.5.70 bk

From: Dave Jones (davej@codemonkey.org.uk)
Date: Thu Jun 05 2003 - 11:29:01 EST


On Fri, Jun 06, 2003 at 02:01:22AM +1000, James Morris wrote:
> The patch below fixes compilation for the MPT Fusion driver, which broke
> with recent changes to the PCI API.
>
> It seems that the code is trying to detect which version of the API its
> being compiled for, but the macro it was looking for has disappeared.

This looks bogus to me.

> diff -urN -X dontdiff bk.pending/drivers/message/fusion/linux_compat.h bk.w1/drivers/message/fusion/linux_compat.h
> --- bk.pending/drivers/message/fusion/linux_compat.h 2003-06-06 00:36:11.000000000 +1000
> +++ bk.w1/drivers/message/fusion/linux_compat.h 2003-06-06 01:48:49.000000000 +1000
> @@ -147,7 +147,7 @@
>
>
> /* PCI/driver subsystem { */
> -#ifndef pci_for_each_dev
> +#ifndef pci_for_each_dev_reverse
> #define pci_for_each_dev(dev) for((dev)=pci_devices; (dev)!=NULL; (dev)=(dev)->next)

What has _reverse got to do with this define ?

Whilst on the subject, how come we still have the _reverse method now
that pci_for_each_dev is dead ?

                Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jun 07 2003 - 22:00:27 EST