Re: [BK PATCH] PCI and PCI Hotplug changes and fixes for 2.5.70

From: Dave Jones (davej@codemonkey.org.uk)
Date: Thu Jun 05 2003 - 03:38:15 EST


On Wed, Jun 04, 2003 at 07:14:52PM -0700, Greg KH wrote:

> > p.s. I'll send these as patches in response to this email to lkml for
> > those who want to see them.
>
> I don't think everyone really wants to see all 63 different
> pci_for_each_dev() removal patches

I'm puzzled why you did..

- pci_for_each_dev(device)
+ while ((device = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, device)) != NULL)

when you could have just added whatever locking pci_find_device() does
to pci_for_each_dev() You'd then not have had to touch any of these
drivers, and it'd look a damn sight better to look at IMO.

                Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jun 07 2003 - 22:00:26 EST