Re: 2.5.70-bk[56] breaks disk partitioning with multiple IDE disks

From: William Lee Irwin III (wli@holomorphy.com)
Date: Mon Jun 02 2003 - 01:05:46 EST


On Sun, Jun 01, 2003 at 05:45:09PM -0700, Adam J. Richter wrote:
> @@ -1436,6 +1437,9 @@
> spin_unlock(&drivers_lock);
> if(idedefault_driver.attach(drive) != 0)
> panic("ide: default attach failed");
> + spin_lock(&drives_lock);
> + list_add_tail(&drive->list, &ata_unused);
> + spin_unlock(&drives_lock);
> return 1;
> }

This looks dubious; check idedefault_driver.attach(). It was just put on
another list. I don't know what you're trying to do but list_move_tail()
would at least not be as oopsable.

-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jun 07 2003 - 22:00:15 EST