On Fri, May 16, 2003 at 07:14:36PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Good job, but...
>
> On Fri, 16 May 2003, Vojtech Pavlik wrote:
> > And while doing the changes I did also some cleanups, mainly removing a
> > bunch of debug code that doesn't seem very useful when lspci does the
> > same job. And removing the config_drive_xfer_rate in favor of functions
> > from ide-timing.h.
>
> Debug code in fe. SiS IDE driver does the same as lspci given you get to
> the point you can run lspci. Dumping of PCI conf regs should be moved to
> generic IDE PCI code as it might be useful for other IDE PCI drivers.
Yes, that would be useful.
> Removing config_drive_xfer_rate() is bad,
> fe. you don't check for bad drives now.
True. That needs to be added to ide_find_best_mode in ide-timing.h.
Which needs to be converted to ide-timing.c.
-- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri May 23 2003 - 22:00:27 EST