Re: [PATCH] 2.4.21-rc1 pointless IDE noise reduction

From: Chuck Ebbert (76306.1226@compuserve.com)
Date: Thu Apr 24 2003 - 10:25:08 EST


Jens Axboe wrote:

>> + return((drive->id->cfs_enable_1 & 0x0400) ? 1 : 0);
>> }
>
> Seconded, it causes a lot more confusion than it does good.

  The return looks like a function call in that last line.

  That's one of the few things I find really annoying -- extra parens
are fine when they make code clearer, but not there.

-------
 Chuck [ C Style Police, badge #666 ]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Apr 30 2003 - 22:00:15 EST