Re: [PATCH] s390 update (1/9): s390 arch fixes.

From: Martin Schwidefsky (schwidefsky@de.ibm.com)
Date: Thu Mar 27 2003 - 07:55:26 EST


> So yes, it's certainly not trivial (otherwise someone would have
> already done it), and I didn't say you should hurry to do it. Also
> note that you don't have to do it all at once, start with #including
> the s390 files on s390x that are exactly the same, and after that
> one file after another can be cleaned up to be s390/s390x clean.

So we are in violent agreement :) From my point of view the merge
should start with the files in include/asm because common s390/s390x
headers would come in handy in the user space as well. The hack we
currently use is to move the s390 / s390x header into subfolders
and use a meta include file that reads in the one or the other
dependent on the compile options (-m31 vs -m64). E.g. for bitsops
this looks like this:

#ifndef __s390x__
#include <asm-s390/bitops.h>
#else
#include <asm-s390x/bitops.h>
#endif

blue skies,
   Martin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:27 EST