On 27 Mar 2003, Antonino Daplas wrote:
> - image->depth should be representative of the data depth
> (currently, either 8 or 1). If image->depth == 1, color expansion can
> now be used to draw the logo, thus there's no need to differentiate
> between mono logo drawing and monochrome expansion.
> + /*
> + * Monochrome expansion and logo drawing functions are the same if
> + * fb_logo.needs_logo == 1.
> + */
> + switch (info->fix.visual) {
> + case FB_VISUAL_MONO10:
> + image.fg_color = (u32) (~(~0UL << fb_logo.depth));
^^^^^^^^^^^^^
> + image.bg_color = 0;
> + image.depth = 1;
> + break;
> + case FB_VISUAL_MONO01:
> + image.bg_color = (u32) (~(~0UL << fb_logo.depth));
^^^^^^^^^^^^^
> + image.fg_color = 0;
> + image.depth = 1;
> + break;
Shouldn't these be info->var.bits_per_pixel instead of fb_logo.depth?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.orgIn personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:27 EST