On Thu, Mar 27, 2003 at 01:20:23PM +1100, Rusty Russell wrote:
> What reason? I just grepped 2.5.66-bk2, and *noone* uses the return
> value, not even to BUG() (you have to grep for all the wrappers for
> notifier_call_unregister, too).
Just more grist for the mill of the ill ...
> (I assume you mean notifier_call_unregister). Yes, but that's another
> battle.
... and it's the same ill. Half-cleaned up stuff sucks. Either remove it
or don't.
> That's because everyone realizes that the return value is useless.
It detects one variant of unmatched register/unregister, so it cannot be
said to be entirely useless. I would not call it entirely useful,
though, I admit.
Beside the point though really, I appear to have made onto Linus'
shitlist at last ... does this mean I finally graduated Linux School ?
regards
john
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:27 EST