Re: [TRIVIAL PATCH][2.5.66] fix for link-error in i810fb_imageblit

From: Russell King (rmk@arm.linux.org.uk)
Date: Tue Mar 25 2003 - 15:18:15 EST


On Tue, Mar 25, 2003 at 12:13:19PM -0800, Andy Pfiffer wrote:
> The error:
> ld -m elf_i386 -T arch/i386/vmlinux.lds.s
> arch/i386/kernel/head.o arch/i386/kernel/init_task.o init/built-in.o
> --start-group usr/built-in.o arch/i386/kernel/built-in.o
> arch/i386/mm/built-in.o arch/i386/mach-default/built-in.o
> kernel/built-in.o mm/built-in.o fs/built-in.o ipc/built-in.o
> security/built-in.o crypto/built-in.o lib/lib.a arch/i386/lib/lib.a
> drivers/built-in.o sound/built-in.o arch/i386/pci/built-in.o
> net/built-in.o --end-group -o .tmp_vmlinux1
> drivers/built-in.o: In function `i810fb_imageblit':
> drivers/built-in.o(.text+0xb59c1): undefined reference to `__memcpy'
> make: *** [.tmp_vmlinux1] Error 1
>
>
> The diff:
>
> diff -Nru a/include/linux/fb.h b/include/linux/fb.h
> --- a/include/linux/fb.h Tue Mar 25 12:02:29 2003
> +++ b/include/linux/fb.h Tue Mar 25 12:02:29 2003
> @@ -4,6 +4,7 @@
> #include <linux/tty.h>
> #include <asm/types.h>
> #include <asm/io.h>
> +#include <asm/string.h>
>
> /* Definitions of frame buffers */

Why linux/fb.h and why asm/string.h when we have linux/string.h?
Shouldn't <linux/string.h> be included by the i810fb driver?

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:21 EST