Re: struct nfs_fattr alignment problem in nfs3proc.c

From: Richard Curnow (Richard.Curnow@superh.com)
Date: Mon Mar 24 2003 - 09:21:58 EST


* Trond Myklebust <trond.myklebust@fys.uio.no> [2003-03-24]:
> >>>>> " " == Richard Curnow <Richard.Curnow@superh.com> writes:
>
> > + if (((unsigned long) arg & 0x7) != 0) {
> > + printk("nfs3_proc_unlink_setup : arg not 8-byte aligned!\n");
> > + }
> > + if (((unsigned long) res & 0x7) != 0) {
> > + printk("nfs3_proc_unlink_setup : res not 8-byte aligned!\n");
> > + }
>
> Nope...
>

Well spotted, ignore those checks :-) At least they showed that the
change higher up was making a difference.

Once there's general agreement about this fix, I'll generate some
patches for up-to-date 2.4 and 2.5.

Cheers
Richard

-- 
Richard \\\ SuperH Core+Debug Architect /// .. At home ..
  P.    /// richard.curnow@superh.com  ///  rc@rc0.org.uk
Curnow  \\\ http://www.superh.com/    ///  www.rc0.org.uk
Speaking for myself, not on behalf of SuperH
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Mar 31 2003 - 22:00:15 EST