Re: [2.4] init/do_mounts.c::rd_load_image() memleak

From: Horst von Brand (vonbrand@inf.utfsm.cl)
Date: Sat Mar 15 2003 - 13:36:06 EST

Next message: Mitch Adair: "2.5.64: menuconfig: help within choice blocks doesn't show?"
Previous message: Horst von Brand: "Re: 2.5.63 accesses below %esp (was: Re: ntfs OOPS (2.5.63))"
In reply to: Oleg Drokin: "Re: [2.4] init/do_mounts.c::rd_load_image() memleak"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Oleg Drokin <green@namesys.com> said:
> On Thu, Mar 13, 2003 at 10:03:08PM +0000, Russell King wrote:
> > > + if (buf)
> > > + kfree(buf);

> > kfree(NULL); is valid - you don't need this check.

> Almost every place I can think of does just this, so I do not see why this
> particular piece of code should be different.

Then the other code should be fixed. This is bloat.

-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                     Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria              +56 32 654239
Casilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Mitch Adair: "2.5.64: menuconfig: help within choice blocks doesn't show?"
Previous message: Horst von Brand: "Re: 2.5.63 accesses below %esp (was: Re: ntfs OOPS (2.5.63))"
In reply to: Oleg Drokin: "Re: [2.4] init/do_mounts.c::rd_load_image() memleak"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Mar 15 2003 - 22:00:43 EST