Re: [2.4] init/do_mounts.c::rd_load_image() memleak

From: Jens Axboe (axboe@suse.de)
Date: Fri Mar 14 2003 - 02:59:57 EST

On Fri, Mar 14 2003, Oleg Drokin wrote:
> Hello!
>
> On Thu, Mar 13, 2003 at 10:03:08PM +0000, Russell King wrote:
>
> > > + if (buf)
> > > + kfree(buf);
> > kfree(NULL); is valid - you don't need this check.
>
> Almost every place I can think of does just this, so I do not see why this
> particular piece of code should be different.

Since when has that been a valid argument? :) 

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sat Mar 15 2003 - 22:00:38 EST