Re: dpt_i2o.c memleak/incorrectness

From: Alan Cox (alan@lxorguk.ukuu.org.uk)
Date: Thu Mar 13 2003 - 14:44:23 EST


On Thu, 2003-03-13 at 18:28, Oleg Drokin wrote:
> Hello!
>
> There is something strange going on in drivers/scsi/dpt_i2o.c in both
> 2.4 and 2.5. adpt_i2o_reset_hba() function allocates 4 bytes
> for "status" stuff, then tries to reset controller, then
> if timeout on first reset stage is reached, frees "status" and returns,
> otherwise it proceeds to monitor "status" (which is modified by hardware
> now, btw), and if timeout is reached, just exits.

Correctly - I2O does the same thing in this case. Its just better to
throw a few bytes away than risk corruption

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Mar 15 2003 - 22:00:36 EST