Re: Memleak in driver for the Specialix SX series cards.

From: Rogier Wolff (R.E.Wolff@BitWizard.nl)
Date: Wed Mar 12 2003 - 16:05:16 EST

Next message: Daniel Jacobowitz: "Re: [ANNOUNCE] BK->CVS (real time mirror)"
Previous message: Roland Dreier: "[PATCH] Re: Dmesg: Use a PAE enabled kernel"
In reply to: Oleg Drokin: "Memleak in driver for the Specialix SX series cards."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, Mar 12, 2003 at 11:41:14PM +0300, Oleg Drokin wrote:
> Hello!
>
> I see there is a memleak in driver for the Specialix SX series cards
> on error exit path in sx_fw_ioctl() (both in 2.4 and 2.5).
> See the patch.
> Found with help of smatch + unfree script.

...
> + kfree (tmp);
> return -EFAULT;

Hi Oleg,

You're right. I left it like this because "root can always mess up the
machine". But once fixed, I agree that it's better this way.

Roger.

-- 
** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2600998 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
* The Worlds Ecosystem is a stable system. Stable systems may experience *
* excursions from the stable situation. We are currently in such an      * 
* excursion: The stable situation does not include humans. ***************
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Daniel Jacobowitz: "Re: [ANNOUNCE] BK->CVS (real time mirror)"
Previous message: Roland Dreier: "[PATCH] Re: Dmesg: Use a PAE enabled kernel"
In reply to: Oleg Drokin: "Memleak in driver for the Specialix SX series cards."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Mar 15 2003 - 22:00:32 EST