Re: [PATCH] (5/8) Eliminate brlock from netfilter

From: Zwane Mwaikambo (zwane@holomorphy.com)
Date: Tue Mar 11 2003 - 20:25:40 EST

Next message: Andrew Morton: "Re: [PATCH] fix kernel oops in generic_unplug_device() for md"
Previous message: Alan Cox: "Re: [PATCH] (8/8) Kill brlock"
In reply to: Stephen Hemminger: "[PATCH] (5/8) Eliminate brlock from netfilter"
Next in thread: Stephen Hemminger: "[PATCH] (6/8) Eliminate brlock from ipv4"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, 11 Mar 2003, Stephen Hemminger wrote:

> void nf_unregister_hook(struct nf_hook_ops *reg)
> {
> - br_write_lock_bh(BR_NETPROTO_LOCK);
> + spin_lock_bh(&nf_lock);
> list_del(&reg->list);
> - br_write_unlock_bh(BR_NETPROTO_LOCK);
> + spin_unlock_bh(&nf_lock);
> +
> + synchronize_kernel();
> }

Won't that have to be list_del_rcu there?

Zwane

-- 
function.linuxpower.ca
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Andrew Morton: "Re: [PATCH] fix kernel oops in generic_unplug_device() for md"
Previous message: Alan Cox: "Re: [PATCH] (8/8) Kill brlock"
In reply to: Stephen Hemminger: "[PATCH] (5/8) Eliminate brlock from netfilter"
Next in thread: Stephen Hemminger: "[PATCH] (6/8) Eliminate brlock from ipv4"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Mar 15 2003 - 22:00:28 EST