On Tuesday March 11, green@namesys.com wrote:
> Hello!
>
> There is trivial memleak on error exit path in nfsd.
> See the patch below.
> Found with help of smatch + enhanced unfree script.
Thanks to all threee of you?
However in keeping with the style of surrounding code I will make it:
===== fs/nfsd/export.c 1.71 vs edited =====
--- 1.71/fs/nfsd/export.c Tue Feb 25 13:08:50 2003
+++ edited/fs/nfsd/export.c Tue Mar 11 17:55:18 2003
@@ -294,7 +294,10 @@
/* client */
len = qword_get(&mesg, buf, PAGE_SIZE);
- if (len <= 0) return -EINVAL;
+ err = -EINVAL;
+ if (len <= 0)
+ goto out;
+
err = -ENOENT;
dom = auth_domain_find(buf);
if (!dom)
NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Mar 15 2003 - 22:00:28 EST