Re: [patch] v4l: create include/media.

From: Gerd Knorr (kraxel@bytesex.org)
Date: Tue Mar 11 2003 - 13:12:40 EST

Next message: Davide Libenzi: "Re: [patch, rfc] lt-epoll ( level triggered epoll ) ..."
Previous message: Jesse Pollard: "Re: [Resending] User Process and a Kernel Thread"
In reply to: Christoph Hellwig: "Re: [patch] v4l: create include/media."
Next in thread: Gerd Knorr: "[patch] v4l: crunch MIN/MAX macros."
Reply: Gerd Knorr: "[patch] v4l: crunch MIN/MAX macros."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, Mar 10, 2003 at 10:02:33PM +0000, Christoph Hellwig wrote:
> > +#define MIN(a,b) (((a)>(b))?(b):(a))
> > +#define MAX(a,b) (((a)>(b))?(a):(b))
>
> Don't do that. Use the kernel's min/max instead.

Yea, I've noticed that too while reviewing the patch, deleted them
(and fixed the code which uses them). But then somehow managed to
mail the old patch version :-/ I'll resort stuff and mail a new
patch later today or tomorrow.

Gerd

-- 
/join #zonenkinder
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Davide Libenzi: "Re: [patch, rfc] lt-epoll ( level triggered epoll ) ..."
Previous message: Jesse Pollard: "Re: [Resending] User Process and a Kernel Thread"
In reply to: Christoph Hellwig: "Re: [patch] v4l: create include/media."
Next in thread: Gerd Knorr: "[patch] v4l: crunch MIN/MAX macros."
Reply: Gerd Knorr: "[patch] v4l: crunch MIN/MAX macros."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Mar 15 2003 - 22:00:26 EST