[2.5] memleak in fs/nfs/inode.c::nfs_get_sb()

• Next message: Jörn Engel: "Re: [2.4 patch] include cfi_cmdset_0020 in drivers/mtd/chips/Makefile"
• Previous message: Oleg Drokin: "[2.5] nfsd/export.c memleak."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hello!

   There is trivial memleak on error exit path in nfs get_sb function.
   See the patch.
   Found with the help of smatch + enhanced unfree script.

Bye,
    Oleg

===== fs/nfs/inode.c 1.72 vs edited =====
--- 1.72/fs/nfs/inode.c Thu Feb 13 15:57:46 2003
+++ edited/fs/nfs/inode.c Tue Mar 11 18:03:07 2003
@@ -1231,6 +1231,7 @@
 
         if (root->size > sizeof(root->data)) {
                 printk("nfs_get_sb: invalid root filehandle\n");
+ kfree(server);
                 return ERR_PTR(-EINVAL);
         }
         /* We now require that the mount process passes the remote address */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Jörn Engel: "Re: [2.4 patch] include cfi_cmdset_0020 in drivers/mtd/chips/Makefile"
• Previous message: Oleg Drokin: "[2.5] nfsd/export.c memleak."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Mar 15 2003 - 22:00:26 EST