Memleak in ircomm_core

From: Oleg Drokin (green@linuxhacker.ru)
Date: Sun Mar 09 2003 - 16:14:34 EST


Hello!

   There seems to be a memleak on error exit path. The same patch should apply
   to 2.5 and 2.4

   Found with help of smatch + enhanced unfree script.

Bye,
    Oleg

===== net/irda/ircomm/ircomm_core.c 1.5 vs edited =====
--- 1.5/net/irda/ircomm/ircomm_core.c Tue Aug 6 22:23:24 2002
+++ edited/net/irda/ircomm/ircomm_core.c Mon Mar 10 00:10:10 2003
@@ -121,8 +121,10 @@
         } else
                 ret = ircomm_open_tsap(self);
 
- if (ret < 0)
+ if (ret < 0) {
+ kfree(self);
                 return NULL;
+ }
 
         self->service_type = service_type;
         self->line = line;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Mar 15 2003 - 22:00:19 EST