Memleak in Windows Logical Disk Manager partition handler

From: Oleg Drokin (green@linuxhacker.ru)
Date: Sun Mar 09 2003 - 15:41:25 EST


Hello!

   Not freeing allocated memory on error exit path.
   See the patch.
   Should apply to both 2.4 and 2.5.
   Found with help of smatch + enhanced unfree script.

Bye,
    Oleg

===== fs/partitions/ldm.c 1.6 vs edited =====
--- 1.6/fs/partitions/ldm.c Mon Aug 12 00:08:42 2002
+++ edited/fs/partitions/ldm.c Sun Mar 9 23:38:15 2003
@@ -1223,8 +1223,10 @@
                 return FALSE;
         }
 
- if (!ldm_parse_vblk (data, len, vb))
+ if (!ldm_parse_vblk (data, len, vb)) {
+ kfree(vb);
                 return FALSE; /* Already logged */
+ }
 
         /* Put vblk into the correct list. */
         switch (vb->type) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Mar 15 2003 - 22:00:19 EST