Re: [PATCH] remove spare cast

From: Geert Uytterhoeven (geert@linux-m68k.org)
Date: Fri Mar 07 2003 - 06:03:36 EST

On Fri, 7 Mar 2003, Linux Kernel Mailing List wrote:
> ChangeSet 1.1068.10.40, 2003/03/06 17:44:05-08:00, alan@lxorguk.ukuu.org.uk
>
> [PATCH] remove spare cast
>
>
> # This patch includes the following deltas:
> # ChangeSet 1.1068.10.39 -> 1.1068.10.40
> # drivers/ide/ide-lib.c 1.6 -> 1.7
> #
>
> ide-lib.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
>
> diff -Nru a/drivers/ide/ide-lib.c b/drivers/ide/ide-lib.c
> --- a/drivers/ide/ide-lib.c Thu Mar 6 18:14:45 2003
> +++ b/drivers/ide/ide-lib.c Thu Mar 6 18:14:45 2003
> @@ -171,7 +171,7 @@
> BUG();
> return min(speed, speed_max[mode]);
> #else /* !CONFIG_BLK_DEV_IDEDMA */
> - return min(speed, (u8)XFER_PIO_4);
> + return min(speed, XFER_PIO_4);
> #endif /* CONFIG_BLK_DEV_IDEDMA */

This reintroduces the following warning (with gcc-2.95.2 and gcc-3.2)

| drivers/ide/ide-lib.c:174: warning: comparison of distinct pointer types
| lacks a cast

which the cast was supposed to kill.

Gr{oetje,eeting}s,

                                                Geert 

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Fri Mar 07 2003 - 22:00:36 EST