Re: sysfs mount point permissions in 2.5.64

From: Patrick Mochel (mochel@osdl.org)
Date: Wed Mar 05 2003 - 18:08:08 EST


On Thu, 6 Mar 2003, Douglas Gilbert wrote:

> In lk 2.5.64 on my i386 box the sysfs mount point
> ( "/sys") changes permission from:
> drwxr-xr-x
> to
> drw-r--r--
> during the boot process. I didn't notice this feature
> in lk 2.5.63 . Chmodding the directory back to its former
> permissions get overridden by subsequent boot sequences.
>
> This change in permissions inhibits non-root users from using
> utilities that scan sysfs for information (e.g. lsscsi).
>
> Is this a feature or otherwise?

This is certainly not intended, and is entirely my fault. The patch below
should fix it.

        -pat

===== fs/sysfs/mount.c 1.5 vs edited =====
--- 1.5/fs/sysfs/mount.c Tue Mar 4 12:17:14 2003
+++ edited/fs/sysfs/mount.c Wed Mar 5 17:06:25 2003
@@ -33,7 +33,7 @@
         sb->s_op = &sysfs_ops;
         sysfs_sb = sb;
 
- inode = sysfs_new_inode(S_IFDIR | S_IRUGO | S_IWUSR);
+ inode = sysfs_new_inode(S_IFDIR | S_IRWXU | S_IRUGO | S_IXUGO);
         if (inode) {
                 inode->i_op = &simple_dir_inode_operations;
                 inode->i_fop = &simple_dir_operations;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Mar 07 2003 - 22:00:30 EST