Re: sys32_ioctl -> compat_ioctl -- generic

• Next message: Beneath: "Re: BUG: EXT3: linux-2.4.21-pre5"
• Previous message: Kamble, Nitin A: "Re: [PATCH][IO_APIC] 2.5.63bk7 irq_balance improvments / bug-fixes"
• In reply to: Pavel Machek: "sys32_ioctl -> compat_ioctl -- generic"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, 4 Mar 2003 00:21:22 +0100 Pavel Machek <pavel@ucw.cz> wrote:
>
> +asmlinkage long compat_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg)

For consistancy, this should be called compat_sys_ioctl.

> +{
> + struct file * filp;

> + filp = fget(fd);

> + /* find the name of the device. */
> + if (path) {
> + struct file *f = fget(fd);

Is it really necessary to do another fget(fd) ?

Also, if you are adding this much code, you should add a copyright notice
to the top of the file ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Beneath: "Re: BUG: EXT3: linux-2.4.21-pre5"
• Previous message: Kamble, Nitin A: "Re: [PATCH][IO_APIC] 2.5.63bk7 irq_balance improvments / bug-fixes"
• In reply to: Pavel Machek: "sys32_ioctl -> compat_ioctl -- generic"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Mar 07 2003 - 22:00:26 EST