Re: [PATCH] fix warning in drivers/net/sis900.c

• Next message: linux@horizon.com: "Re: Playing with 2.5.63: APM blanking and "bio too big""
• Previous message: fauxpas@temp123.org: "Re: IOAPIC on Via KT266a"
• In reply to: Martin J. Bligh: "[PATCH] fix warning in drivers/net/sis900.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Martin J. Bligh wrote:
> drivers/net/sis900.c: In function `set_rx_mode':
> drivers/net/sis900.c:2100: warning: passing arg 2 of `set_bit' from incompatible pointer type
>
> I just cast this. Seems to work fine at the moment, so presumably it's
> correct.

Nope -- set_bit wants to work on a real unsigned long. While your patch
will work, the proper fix is to not use set_bit :)

        Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: linux@horizon.com: "Re: Playing with 2.5.63: APM blanking and "bio too big""
• Previous message: fauxpas@temp123.org: "Re: IOAPIC on Via KT266a"
• In reply to: Martin J. Bligh: "[PATCH] fix warning in drivers/net/sis900.c"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Mar 07 2003 - 22:00:16 EST